Re: Fix for 'extern "C"' indenting - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Fix for 'extern "C"' indenting
Date
Msg-id 200111082041.fA8Kfi822765@candle.pha.pa.us
Whole thread Raw
In response to Re: Fix for 'extern "C"' indenting  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Attached is a patch which is a run of an improved pgindent over several
> > include files that contained 'extern "C"' blocks.
> > Do people want this applied or should we just live with a ugly indenting
> > of a few C files for 7.2?
>
> I'd say go for it ... particularly if you already committed the
> corresponding pgindent fix.  It would be weird to ship a pgindent
> that doesn't agree with the formatted files.

Done.  FYI, pgindent sometimes doesn't match what we ship because I
tweek it for the _next_ run, which may not happen for 6-9 months.

The interesting case with 'extern "C"' is that pgindent was properly
indenting the block, but in this case, it just made no sense.  It also
thought it was in some kind of function and didn't understand certain
prototypes.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: MD5 support for ODBC
Next
From: Tom Lane
Date:
Subject: Call for objections: revision of keyword classification