Re: contrib/fuzzystrmatch - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: contrib/fuzzystrmatch
Date
Msg-id 200110291941.f9TJfbT14561@candle.pha.pa.us
Whole thread Raw
In response to contrib/fuzzystrmatch  (Joe Conway <joseph.conway@home.com>)
List pgsql-patches
OK, I see your patch but it appears to just move a blank line to below
the macro and it shows two calls to End_Phoned_Word while I see only one
in the file.  I am sure this was some kind of cut/paste wrapping
problem in the email.

I applied the following patch which does what I think you intended,
which is to add a trailing semicolon.  This is very common because
incorrectly structured macro allowed the old syntax while the correct
macro does not.

Thanks.


---------------------------------------------------------------------------


> Here's a trivial patch for fuzzystrmatch.c (broken due to macro cleanup).
>
> -- Joe
>
>
> --- fuzzystrmatch.c.orig    Sun Oct 28 22:45:46 2001
> +++ fuzzystrmatch.c    Sun Oct 28 22:42:54 2001
> @@ -341,7 +341,7 @@
>           /* On the off chance we were given nothing but crap... */
>           if (Curr_Letter == '\0')
>           {
> -         End_Phoned_Word
> +         End_Phoned_Word;
>
>         return META_SUCCESS;    /* For testing */
>           }
>       }
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
Index: contrib/fuzzystrmatch/fuzzystrmatch.c
===================================================================
RCS file: /cvsroot/pgsql/contrib/fuzzystrmatch/fuzzystrmatch.c,v
retrieving revision 1.4
diff -c -r1.4 fuzzystrmatch.c
*** contrib/fuzzystrmatch/fuzzystrmatch.c    2001/10/25 05:49:19    1.4
--- contrib/fuzzystrmatch/fuzzystrmatch.c    2001/10/29 19:36:35
***************
*** 341,348 ****
          /* On the off chance we were given nothing but crap... */
          if (Curr_Letter == '\0')
          {
!             End_Phoned_Word
!                 return META_SUCCESS;    /* For testing */
          }
      }

--- 341,348 ----
          /* On the off chance we were given nothing but crap... */
          if (Curr_Letter == '\0')
          {
!             End_Phoned_Word;
!             return META_SUCCESS;    /* For testing */
          }
      }


pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Add regression test for ALTER TABLE / ADD UNIQUE
Next
From: Bruce Momjian
Date:
Subject: Re: update src/interfaces/libpq/zh_TW.po