On Mon, Sep 24, 2001 at 09:18:42AM +0200, Christof Petig wrote:
> well at first I could not believe what I was seeing ...
:-)
> Look at the following code (ecpg/lib/execute.c):
>
> const char *locale=setlocale(LC_NUMERIC, NULL);
> setlocale(LC_NUMERIC, "C");
> [....]
> setlocale(LC_NUMERIC, locale);
>
>
> Well at least on glibc-2.2 it seems that setlocale retuns a pointer to
> malloced memory, and frees this pointer on subsequent calls to
Doesn't look that way on my system. The following programs simply dumps core
in free().
#include <locale.h>
#include <stdio.h>
main()
{
const char *locale=setlocale(LC_NUMERIC, NULL);
printf("%c\n", locale);
free(locale);
}
> setlocale. This is standard conformant and has good reasons. But used as
You're partially right. Standard says "This string may be allocated in
static storage." So, yes, with your patch we are on the safe side. I just
committed the changes.
Michael
--
Michael Meskes
Michael@Fam-Meskes.De
Go SF 49ers! Go Rhein Fire!
Use Debian GNU/Linux! Use PostgreSQL!
