Re: Beta Monday? - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Beta Monday?
Date
Msg-id 200109071501.f87F1xX22206@candle.pha.pa.us
Whole thread Raw
In response to Re: Beta Monday?  (Karel Zak <zakkr@zf.jcu.cz>)
List pgsql-hackers
> On Fri, Sep 07, 2001 at 10:39:19AM -0400, Bruce Momjian wrote:
> > > Karel Zak <zakkr@zf.jcu.cz> writes:
> > > >> But here is the tail of the output:
> > > >> UX:cc: WARNING: debugging and optimization mutually exclusive; -O disabled
> > > >> UX:acomp: ERROR: "encnames.c", line 36: syntax error in macro parameters
> > > >                   ^^^^^^^^^^^^^
> > > 
> > > > #define encdebug(_format, _a...)
> > > >    ^^^^^^^^^^^
> > > >  line 36
> > > 
> > > >  I don't see some problem with my gcc. Or I something overlook?
> > > 
> > > "..." in macro parameters is a gcc-ism.  This code is unportable and
> > > must be fixed.
> > 
> > Yes, that stuff can't be done.  We do use ## to bind macro params, but
> > we don't do variable-length macro calls.  This is debug stuff anyway so
> > I am looking at how to get it compiling right away.
> 
>  Hmm.. my world is comiled by 'gcc' and I'm still must learning that 
> here are some cathedrals and not bazaars only :-) Sorry.
> 
>  OK, please erase all these debug macros (encdebug). I used it for binary 
> search check only. It's not needful. Do you want a patch (but not until 
> Monday)?

OK, macros gone.  Should compile fine now for people using multibyte.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Beta Monday?
Next
From: Larry Rosenman
Date:
Subject: Re: [COMMITTERS] pgsql/src/backend/utils/mb encnames.c