Re: encoding names - Mailing list pgsql-patches

From Tatsuo Ishii
Subject Re: encoding names
Date
Msg-id 20010903100244C.t-ishii@sra.co.jp
Whole thread Raw
In response to Re: encoding names  (Karel Zak <zakkr@zf.jcu.cz>)
Responses Re: encoding names
Re: encoding names
List pgsql-patches
Thanks for the patches. I will check them as soon as possible.  Also,
I would like to ask Hiroshi and others who are working for the ODBC
driver to check if everything is ok.

>  I found new bug in command/variable.c in parse_client_encoding(), nobody
> probably never see this error:
>
> if (pg_set_client_encoding(encoding))
> {
>     elog(ERROR, "Conversion between %s and %s is not supported",
>                      value, GetDatabaseEncodingName());
> }
>
> because pg_set_client_encoding() returns -1 for error and 0 as true.
> It's fixed too.

??? In C, anthing other than 0 is evaluted to true. So the original
code would work as expected.
--
Tatsuo Ishii

pgsql-patches by date:

Previous
From: Rene Pijlman
Date:
Subject: PostgreSQL/JDBC Test Suite Howto
Next
From: Karel Zak
Date:
Subject: Re: encoding names