Re: [PATCH] Prevent pg_dump running out of memory - Mailing list pgsql-patches

From Martijn van Oosterhout
Subject Re: [PATCH] Prevent pg_dump running out of memory
Date
Msg-id 20010828010622.D32309@svana.org
Whole thread Raw
In response to Re: [PATCH] Prevent pg_dump running out of memory  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
On Mon, Aug 27, 2001 at 10:42:34AM -0400, Tom Lane wrote:
> Martijn van Oosterhout <kleptog@svana.org> writes:
> > [ use a cursor for pg_dump -d ]
>
> Excellent idea.  Thanks!

No problems.

> > Also, it seems there is no regression test for pg_dump. Is this intentional
> > or has noone come up with a good way to test it?
>
> The latter.  We certainly need one...

The only thing I can think of right now is for other parts of the regression
tests to leave various tables, triggers, etc lying around. Then somewhere
near the end, do a pg_dump regress | psql newdb (for various options of
pg_dump) and then somehow compare the two databases.

The comparison would be the tricky part because you should avoid using
pg_dump since that is what you are testing...

--
Martijn van Oosterhout <kleptog@svana.org>
http://svana.org/kleptog/
> It would be nice if someone came up with a certification system that
> actually separated those who can barely regurgitate what they crammed over
> the last few weeks from those who command secret ninja networking powers.

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Prevent pg_dump running out of memory
Next
From: Bruce Momjian
Date:
Subject: Re: patch for JDBC1 build problems