Re: official submission for OU8/UnixWare sharedlib patch - Mailing list pgsql-patches

From Larry Rosenman
Subject Re: official submission for OU8/UnixWare sharedlib patch
Date
Msg-id 20010827090910.A22765@lerami.lerctr.org
Whole thread Raw
In response to official submission for OU8/UnixWare sharedlib patch  (Larry Rosenman <ler@lerctr.org>)
Responses Re: official submission for OU8/UnixWare sharedlib patch  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
* Peter Eisentraut <peter_e@gmx.net> [010827 09:08]:
> Larry Rosenman writes:
>
> > I sent this to -hackers and peter_e, but thought it ought to go to
> > -patches as well.
>
> The -Bdynamic probably ought to disappear.
that was there already, but I have no objections.  I was trying to
make minimal changes.

LER

>
> > This fixes the regression test .so builds on sysv5 systems:
> > I believe this will fix peter_e's problen with gcc.
> >
> > Please advise if this is a bad idea...
> >
> > Index: Makefile.unixware
> > ===================================================================
> > RCS file: /home/projects/pgsql/cvsroot/pgsql/src/makefiles/Makefile.unixware,v
> > retrieving revision 1.9
> > diff -c -r1.9 Makefile.unixware
> > *** Makefile.unixware    2000/12/16 18:14:25    1.9
> > --- Makefile.unixware    2001/08/25 18:22:36
> > ***************
> > *** 16,21 ****
> >   else
> >   CXXFLAGS_SL = -K PIC
> >   endif
> >
> >   %.so: %.o
> > !     $(LD) -G -Bdynamic -o $@ $<
> > --- 16,26 ----
> >   else
> >   CXXFLAGS_SL = -K PIC
> >   endif
> > + ifeq ($(GCC), yes)
> > + SO_FLAGS = -shared
> > + else
> > + SO_FLAGS = -G
> > + endif
> >
> >   %.so: %.o
> > !     $(CC) $(SO_FLAGS) -Bdynamic -o $@ $<
> >
> >
>
> --
> Peter Eisentraut   peter_e@gmx.net   http://funkturm.homeip.net/~peter

--
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 972-414-9812                 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

pgsql-patches by date:

Previous
From: Martijn van Oosterhout
Date:
Subject: [PATCH] Prevent pg_dump running out of memory
Next
From: Peter Eisentraut
Date:
Subject: Re: official submission for OU8/UnixWare sharedlib patch