Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal support - Mailing list pgsql-patches

> > It adds new configure switch
> > --enable-pltcl-utf. Without this switch patch does nothing.
>
> This is not a good approach, since it relies on the user to know whether
> he needs to do this or not.  Seems like looking at the Tcl version
> number would be more appropriate: if version >= 8.3 then make these
> changes.  You could do that in the code, without any configure patch,
> using #if's on TCL_MAJOR_VERSION and TCL_MINOR_VERSION (see libpgtcl
> for examples).

I asked him this already and he said that there is extra overhead for
the conversion that many wouldn't want.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026