On Fri, Aug 17, 2001 at 06:11:00PM +0200, Peter Eisentraut wrote:
> Karel Zak writes:
>
> > - possible is use synonyms for encoding (an example ISO-8859-1,
> > Latin1, l1)
>
> On the choice of synonyms: Do we really want to add that many synonyms
> that are not the standard name? I think the following are not necessary:
>
> cyrillic, cp819, ibm819, isoir100x, l1-4
IMHO is not problem if PG will understand to more aliases, or is here some
relevant problem with it? :-)
> ISO 8859 is a pretty well-know term these days.
>
> KOI8 needs to be aliased as koi8r. Unicode is not a valid encoding name,
Agree.
> actually. Do you know what encoding is stands for and could you add that
> as an alias?
>
> On the code:
>
> #ifdef WIN32
> #include "win32.h"
> #else
> #include <unistd.h>
> #endif
>
> needs to be written as
>
> #ifdef WIN32
> # include "win32.h"
> #else
> # include <unistd.h>
> #endif
>
> for portability.
OK, but sounds curious (how compiler has problem with it?)
> For extra credit: A patch to configure and the documentation.
:-) needs time... but yes, I add it to next patch version.
Thanks for suggestions.
Karel
--
Karel Zak <zakkr@zf.jcu.cz>
http://home.zf.jcu.cz/~zakkr/
C, PostgreSQL, PHP, WWW, http://docs.linux.cz, http://mape.jcu.cz
