Re: crypt and null termination - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: crypt and null termination
Date
Msg-id 200108170259.f7H2xec05446@candle.pha.pa.us
Whole thread Raw
In response to Re: crypt and null termination  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > It seems to say that the salt passed to crypt should be null-terminated,
> 
> Hmm.  The HPUX man page for crypt() just says that
>     salt is a two-character string chosen from the set [a-zA-Z0-9./]
> which I think is the traditional spec.  Looks like BSD has adopted some
> local extensions.
> 
> Note that the BSD page specifies that the extended salt format starts
> with '_', which is not one of the allowed characters in the traditional
> format.  I bet they check that before trying to fetch more than 2 bytes.
> The second paragraph you quote doesn't say anything about null
> termination.
> 
> Still, it wouldn't be a bad idea to add a null byte ... couldn't hurt.

That was my feeling, and it may explain some of our crypt() platform
failures!

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Doug McNaught
Date:
Subject: Re: crypt and null termination
Next
From: He Weiping
Date:
Subject: plpgsql's variable name can't be the same with table column?