Re: patch for contrib/intarray (current CVS) - Mailing list pgsql-hackers

Sure.

> Oleg Bartunov <oleg@sai.msu.su> writes:
> > please apply attached patch to current CVS.
> > 1. Fixed error with empty array ( '{}' ),
> >    test data changed to include such data
> > 2. Test a dimension of an array ( we support only one-dimension)
> 
> Looks okay in a quick glance, except error message spelling is poor:
> 
> ! #define ARRISNULL(x) ( (x) ? ( ( ARR_NDIM(x) == NDIM ) ? ( ( ARRNELEMS( x ) ) ? 0 : 1 ) : ( ( ARR_NDIM(x) ) ?
(elog(ERROR,"Arrayis not one-dimentional: %d dimentions", ARR_NDIM(x)),1) : 1 ) ) : 1 )
 
> 
> Should be "one-dimensional" and "dimensions".  Bruce, would you fix that
> when you apply it?
> 
>             regards, tom lane
> 

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026