Re: Python (PyGreSQL) make install patch - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Python (PyGreSQL) make install patch
Date
Msg-id 200105241650.f4OGoq605108@candle.pha.pa.us
Whole thread Raw
In response to Python (PyGreSQL) make install patch  (Jason Tishler <Jason.Tishler@dothill.com>)
List pgsql-patches
Looks good to me.

Your patch has been added to the PostgreSQL unapplied patches list at:

    http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it withing the next 48 hours.


> The attached patch changes src/interfaces/python/GNUmakefile to use the
> value of DESTDIR like the rest (or at least most) of the PostgreSQL
> makefiles.  I found this problem when trying to package a pre-built
> Cygwin PostgreSQL distribution, but this problem is platform independent.
>
> The problem manifests itself when one tries to install into a stagging
> area (e.g., to build a tarball) instead of a real install.  In this case,
> pg.py and _pgmodule$(SO) still end up being installed in the configured
> prefix directory ignoring the value of DESTDIR.
>
> Unfortunately, this patch does not handle the case where PostgreSQL
> and Python are configured with different prefixes.  Since the Python
> Makefile is automatically generated and does not use DESTDIR, I believe
> that this issue will be difficult to correct.  If anyone has ideas on
> how to fix this issue, then I'm quite willing to rework the patch to
> take the suggestion into account.
>
> I tested this patch on Cygwin and Linux.
>
> Thanks,
> Jason
>
> --
> Jason Tishler
> Director, Software Engineering       Phone: 732.264.8770 x235
> Dot Hill Systems Corp.               Fax:   732.264.8798
> 82 Bethany Road, Suite 7             Email: Jason.Tishler@dothill.com
> Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Cygwin plpython patch
Next
From: Bruce Momjian
Date:
Subject: Re: Cygwin PostgreSQL Python Module Patch