Re: Remove sort files - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Remove sort files
Date
Msg-id 200105230055.f4N0tpV17150@candle.pha.pa.us
Whole thread Raw
In response to Re: Remove sort files  ("Michael Richards" <michael@fastmail.ca>)
List pgsql-patches
> > The only unusual part is the use of system("find...rm...") to
> > remove the files in pg_sorttemp.  Seemed cleaner than doing fancy
> > directory walking code in C.
>
> Should this figure out and use a path to the find command? Unless
> postgres sets CWD, is it possible as-is to coerce it into rming some
> files you did not intend to have rm'd? I didn't have/spend time
> looking at it with a fine toothcomb, but usually calling find and rm
> without an explicit path is a Bad Thing(tm).

I believe it is in /usr/bin on every OS, right?  My guess is I have to
have configure find it.  Let me get on that for 'find' and 'rm'.  If
they are not found, I will skip it.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: "Michael Richards"
Date:
Subject: Re: Remove sort files
Next
From: Bruce Momjian
Date:
Subject: Re: Remove sort files