Re: pgsql/src/backend/access/nbtree nbtutils.c - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql/src/backend/access/nbtree nbtutils.c
Date
Msg-id 200105171556.f4HFuwr03171@candle.pha.pa.us
Whole thread Raw
In response to Re: pgsql/src/backend/access/nbtree nbtutils.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql/src/backend/access/nbtree nbtutils.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> >> Bruce Momjian - CVS <momjian@hub.org> writes:
> > Small cleanup of spacing.
> >>
> >> Kinda pointless when pgindent is going to change it right back, eh?
>
> > There were empty lines around stuff:
>
> The change I was looking at was removal of a blank line just before a
> comment block.  pgindent inserts those whether you want 'em or not
> (one of several things I do not like about it).  The lines you removed
> were in fact inserted by the last pgindent run.

Wow, that stinks.  Let me try a test.

Ewe, yes, I see that now.  A blank line is force before all comment
blocks.

It was the -bbb indent flag:

     -bbb, -nbbb     If -bbb is specified, a blank line is forced before every
                     block comment.  Default: -nbbb.

I have removed that flag from pgindent.

I guess I added =bbb that so a normal comment block had a blank line
before it.  Do you normally like a blank line before comment blocks when
there is no brace on the line above?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql/src/backend/access/nbtree nbtutils.c
Next
From: Bruce Momjian - CVS
Date:
Subject: pgsql/src/tools/pgindent pgindent