Re: pgsql/ ontrib/pg_dumplo/lo_export.c ontrib/pg_ ... - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql/ ontrib/pg_dumplo/lo_export.c ontrib/pg_ ...
Date
Msg-id 200103221829.NAA08009@candle.pha.pa.us
Whole thread Raw
In response to Re: pgsql/ ontrib/pg_dumplo/lo_export.c ontrib/pg_ ...  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Yea, kind of bad, huh?  That is the only way to prevent the comment
> > wrapping, unless we add /* ---  to those comments.
>
> What I'm complaining about is that that comment HAD the dashes, and
> you gratuitously removed them.  You promised me some time ago that
> pgindent wouldn't mess up dash-protected comments.  You're violating
> the terms of that armistice ...

Yes, I did.

I assumed /* ---- comments were used to protect pre-indented comment
text, an item Thomas has mentioned, and something I did properly
preserve.  I did not know it was being used for x = y wrap protection.

I just did:

    $ rgrepc '        [/ ]\* .*=$'

and

    $ rgrepc '        [/ ]\* ='

and see the comment you mentioned.  Let me go through and look at all
the equals wraps and re-add the dashes for you.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql/ ontrib/pg_dumplo/lo_export.c ontrib/pg_ ...
Next
From: Tom Lane
Date:
Subject: pgsql/src/bin/psql mainloop.c startup.c