Re: pgindent run? - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: pgindent run?
Date
Msg-id 200103220517.AAA15343@candle.pha.pa.us
Whole thread Raw
In response to Re: pgindent run?  (The Hermit Hacker <scrappy@hub.org>)
List pgsql-hackers
> > The problem is that the small ones don't apply cleanly if they don't
> > match the indenting in the source.
> 
> but ... if they are small, manually merging isn't that big of a deal ...
> and if anyone else has been working in that code since release, there is a
> chance it won't mergef cleanly ...

Yes, they can be manually merged, but that is much more error-prone than
pgindent itself, at least with me patching them.  :-)

Yes, I agree there is a risk.  I was quite scared the first time I ran
it on the tree and did the commit.  At this point, there are very few
changes to it, so I feel a little better, and the stuff gets caught
somehow if there is a problem.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: The Hermit Hacker
Date:
Subject: Re: pgindent run?
Next
From: Philip Warner
Date:
Subject: Re: More on elog and error codes