Re: [HACKERS] ODBC Driver int8 Patch - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] ODBC Driver int8 Patch
Date
Msg-id 200101231614.LAA10067@candle.pha.pa.us
Whole thread Raw
Responses Re: Re: [HACKERS] ODBC Driver int8 Patch  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
I am waiting for someone to comment on this.  Anyone?



[ Charset ISO-8859-1 unsupported, converting... ]
> Hi Bruce,
>
> Did you accept this patch in the end or was it rejected?
>
> Regards, Dave.
>
> > -----Original Message-----
> > From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
> > Sent: 16 January 2001 16:50
> > To: Dave Page
> > Cc: 'pgsql-hackers@postgresql.org'
> > Subject: Re: [HACKERS] ODBC Driver int8 Patch
> >
> >
> > As I remember, the problem is that this makes us match the
> > ODBC v2 spec,
> > but then we would not match the v3 spec.  Is that correct?
> >
> >
> > [ Charset ISO-8859-1 unsupported, converting... ]
> > > Hi,
> > >
> > > It was suggested that I post this patch here as no notice
> > was taken of it
> > > when posted to interfaces!
> > >
> > > This fixes problems with int8 columns which are reported by
> > the driver as
> > > SQL_BIGINT rather than SQL_CHAR as per the ODBC v2 spec.
> > Specifically, I
> > > have had problems with MS ADO - any queries that contain an
> > int8 column in
> > > the resultset will *always* return an empty recordset.
> > >
> > > Regards,
> > >
> > > Dave.
> > >
> > > *** pgtypes.c.orig      Fri Dec 22 09:12:22 2000
> > > --- pgtypes.c   Fri Dec 22 09:12:22 2000
> > > ***************
> > > *** 217,223 ****
> > >         case PG_TYPE_XID:
> > >         case PG_TYPE_INT4:          return SQL_INTEGER;
> > >
> > > !       case PG_TYPE_INT8:                      return SQL_BIGINT;
> > >         case PG_TYPE_NUMERIC:           return SQL_NUMERIC;
> > >
> > >         case PG_TYPE_FLOAT4:        return SQL_REAL;
> > > --- 217,223 ----
> > >         case PG_TYPE_XID:
> > >         case PG_TYPE_INT4:          return SQL_INTEGER;
> > >
> > > !       case PG_TYPE_INT8:                      return SQL_CHAR;
> > >         case PG_TYPE_NUMERIC:           return SQL_NUMERIC;
> > >
> > >         case PG_TYPE_FLOAT4:        return SQL_REAL;
> > >
> >
> >
> > --
> >   Bruce Momjian                        |  http://candle.pha.pa.us
> >   pgman@candle.pha.pa.us               |  (610) 853-3000
> >   +  If your life is a hard drive,     |  830 Blythe Avenue
> >   +  Christ can be your backup.        |  Drexel Hill,
> > Pennsylvania 19026
> >
>


--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Support for cursors in PL/pgSQL
Next
From: Thomas Lockhart
Date:
Subject: Re: Re: [HACKERS] ODBC Driver int8 Patch