Re: Re: [PATCHES] PostgreSQL virtual hosting support - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Re: [PATCHES] PostgreSQL virtual hosting support
Date
Msg-id 200011140101.UAA20232@candle.pha.pa.us
Whole thread Raw
In response to Re: Re: [PATCHES] PostgreSQL virtual hosting support  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > +     if (conn->pghostaddr && conn->pghostaddr[0] == '/')
> > +     {
> > +         if (conn->pgunixsocket)
> > +             free(conn->pgunixsocket);
> > +         conn->pgunixsocket = conn->pghostaddr;
> > +         conn->pghostaddr = NULL;
> > +     }
> 
> I would be inclined to think you should NOT look for a path in
> pghostaddr, since my understanding is that that's supposed to be a
> numeric IP address and nothing but.  Otherwise this looks pretty
> reasonable.

Fixed. Thanks.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Mark Hollomon
Date:
Subject: Re: CREATE MODULE (was: Coping with 'C' vs 'newC' function language names)
Next
From: Bruce Momjian
Date:
Subject: Re: Re: [PATCHES] PostgreSQL virtual hosting support