Re: incompatible changes of PQsetdbLogin() - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: incompatible changes of PQsetdbLogin()
Date
Msg-id 20001022181212J.t-ishii@sra.co.jp
Whole thread Raw
In response to Re: incompatible changes of PQsetdbLogin()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> Tatsuo Ishii <t-ishii@sra.co.jp> writes:
> > It seems some incompatible changes have been made between 7.0 and
> > current. In 7.0, if a parameter is NULL OR a null string (""), then
> > the value from an environment variable is applied. However in current
> > ONLY NULL is considered. Is there any reason for this?
> 
> Peter E. did that recently, after discussion that concluded it was a
> good idea --- otherwise there is no way to override an environment
> variable with an empty string.  Do you have an example where it's
> a bad idea?

For PGHOST Peter E.'s changes seem reasonable. But what about PGPORT?
In 7.0.x, if pgport is an empty string and PGPORT environment variable
is not set, then the default port no. (5432) is used. However, in
current, if pgport is an empty string, then the empty string is
assumed as a port no. that causes a failure on connection even if
PGPORT variable is set.
--
Tatsuo Ishii


pgsql-hackers by date:

Previous
From: Denis Perchine
Date:
Subject: Re: Re: [PATCHES] Patch to support transactions with BLOBs for current CVS
Next
From: Bruce Hartzler
Date:
Subject: howto: install posgresql on darwin/osxpb