Re: binary operators on integers - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: binary operators on integers
Date
Msg-id 200010170400.AAA06830@candle.pha.pa.us
Whole thread Raw
In response to binary operators on integers  (Marko Kreen <marko@l-t.ee>)
Responses Re: binary operators on integers  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Can someone comment on this?



> Here is my next take on binary operators for integers.
> It implements the following operators for int2/int4/int8:
>
>  ~ - not
>  & - and
>  ^ - xor
>  | - or
>  << - shift left
>  >> - shift right
>
> Notes:
>
> * My original choice for xor was '#' because the '^' operator conflicts
>   with power operator on floats but Tom Lane said:
>
> > Well, you *could* use '^' since there's no definition of it for integer
> > operands.  But that would mean that something like '4^2', which was
> > formerly implicitly coerced to float and interpreted as floating
> > power function, would suddenly mean something different.  Again a
> > serious risk of silently breaking applications.  This doesn't apply to
> > '|' though, since it has no numeric interpretation at all right now.
>
>   As the bit-string uses '^' too for xor-ing it would be nice to be
>   consistent.  I am quite unsure on this matter.  The patch now seems
>   otherwise sane to me, this is the only issue left.
>
> * On << and >> the second argument is always int32 as this seems
>   to be the 'default' int type in PostgreSQL.
>
> * Oids used are 1874 - 1909.
>
> Comments?
>
> Patch is against current CVS.
>
> --
> marko
>

[ Attachment, skipping... ]


--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Network Patch to specify IP Address to Bind to
Next
From: Tom Lane
Date:
Subject: Re: binary operators on integers