Re: Minor patch to C++ large object interface (cures two ills) - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Minor patch to C++ large object interface (cures two ills)
Date
Msg-id 200009251253.IAA03311@candle.pha.pa.us
Whole thread Raw
In response to Minor patch to C++ large object interface (cures two ills)  (Adam Haberlach <adam@newsnipple.com>)
Responses Re: Minor patch to C++ large object interface (cures two ills)
List pgsql-patches
First, I need context diffs, diff -c.  Second, does the END cause
problems in cases where Close() is called more than once?  For example,
Close is called as part of PgLargeObject::Open.


> For quite some time, the C++ large object interface has been getting
> away with not declaring transactions,  Looks like nobody noticed that
> it wasn't getting away with it since 6.5.
>
> Also, it seems to have had a definition for the mythical
> PgLargeObject::::LOid() function, but never seemed to have an
> implementation.
>
> (forgive me if this isn't a correct patch format.  Pretty minor, in
> any case)
>
>
> socket:cvs diff pglobject.cc
> Index: pglobject.cc
> ===================================================================
> RCS file: /home/projects/pgsql/cvsroot/pgsql/src/interfaces/libpq++/pglobject.cc,v
> retrieving revision 1.6
> diff -r1.6 pglobject.cc
> 58a59
> >   Exec("END");
> 67a69
> >   Exec("BEGIN");
> 149a152,155
> > Oid PgLargeObject::LOid()
> > {
> >   return pgObject;
> > }
>
>
> --
> Adam Haberlach            | A billion hours ago, human life appeared on
> adam@newsnipple.com       | earth.  A billion minutes ago, Christianity
> http://www.newsnipple.com | emerged.  A billion Coca-Colas ago was
> '88 EX500                 | yesterday morning. -1996 Coca-Cola Ann. Rpt.
>


--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Unbreak plperl building
Next
From: Bruce Momjian
Date:
Subject: Re: oracle compatible func.