Re: Questionable coding in proc.c & lock.c - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Questionable coding in proc.c & lock.c
Date
Msg-id 200007281551.LAA28326@candle.pha.pa.us
Whole thread Raw
In response to Re: Questionable coding in proc.c & lock.c  (Thomas Lockhart <lockhart@alumni.caltech.edu>)
List pgsql-hackers
> > I think maybe what needs to be done to fix all this is to restructure
> > postgres.c's interface to the parser/rewriter.  What we want is to
> > run just the yacc grammar initially to produce a list of raw parse
> > trees (which is enough to detect begin/commit/rollback, no?)  Then
> > postgres.c walks down that list, and for each element, if it is
> > commit/rollback OR we are not in abort state, do parse analysis,
> > rewrite, planning, and execution.  (Thomas, any comments here?)
> 
> Sure, why not (restructure postgres.c that is)? I was just thinking
> about how to implement "autocommit" and was considering doing a hack in
> analyze.c which just plops a "BEGIN" in front of the existing query. But

Man, that is something I would do.  :-)

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Re: Another TODO: insert/update...returning
Next
From: Tom Lane
Date:
Subject: Re: Questionable coding in proc.c & lock.c