Re: DROP COLUMN status - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: DROP COLUMN status
Date
Msg-id 200006081541.LAA01566@candle.pha.pa.us
Whole thread Raw
In response to Re: DROP COLUMN status  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: DROP COLUMN status  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> "Hiroshi Inoue" <Inoue@tpf.co.jp> writes:
> > The implementation makes the dropped column invisible by
> > changing its attnum to -attnum - offset(currently 20) and
> > attnam to ("*already Dropped%d",attnum).
> 
> Ugh.  No wonder you had to hack so many places in such an ugly fashion.
> Why not leave the attnum as-is, and just add a bool saying "column is
> dropped" to pg_attribute?  As long as the parser ignores columns marked
> that way for field lookup and expansion of *, it seems the rest of the
> system wouldn't need to treat dropped columns specially in any way.

If we leave it as positive, don't we have to change user applications
that query pg_attribute so they also know to skip it?

--  Bruce Momjian                        |  http://www.op.net/~candle pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Proposal: TRUNCATE TABLE table RESTRICT
Next
From: Mike Mascari
Date:
Subject: Re: Proposal: TRUNCATE TABLE table RESTRICT