Re: Proposed cleanup of generated header files - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Proposed cleanup of generated header files
Date
Msg-id 200005281842.OAA25107@candle.pha.pa.us
Whole thread Raw
In response to Proposed cleanup of generated header files  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> It's bothered me for some time that backend files need to be compiled
> with -I src/backend as well as -I src/include.  AFAICT this is just
> because the two header files that are generated on-the-fly (parse.h
> and fmgroids.h, formerly known as fmgr.h) are included from src/backend
> rather than being inserted into the include tree, which it seems to me
> is where they should be.  Any objections if I rearrange the makefiles
> so that these files get placed under include/ when they are built,
> and then -I src/backend goes away?
> 
> (In case anyone is wondering, there are no platform-dependencies in
> either file.  We could distribute them as part of the distribution
> tarball --- in fact we already do so for parse.h.  So I don't see
> that installing them into src/include would create any problems for
> multiplatform builds.)

Agreed.

--  Bruce Momjian                        |  http://www.op.net/~candle pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Proposed cleanup of generated header files
Next
From: The Hermit Hacker
Date:
Subject: Re: Proposed cleanup of generated header files