Re: [HACKERS] Number of index fields configurable - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] Number of index fields configurable
Date
Msg-id 200001101609.LAA15630@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Number of index fields configurable  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > I will tweek the code to properly check for trailing numbers.  Right now
> > multiple spaces cause problems, and trailing numbers are ignored.  With
> > oidn, we can get away with trailing zeros because an oid of 0 is
> > invalid, but with int2n, a zero is valid, so I think we can't just ignore
> > extra trailing zeros.  We can pad with zeros, however.  Comments?
> 
> For the primary use of these things, which is attribute numbers in
> pg_index, padding or dropping zeroes is correct behavior --- unused
> positions in the vector will have zero values, same as for the oid
> vector.  I think it's OK to define the type's behavior suitably for
> the system's use, because it's not intended as a general-purpose user
> type; users oughta be using int2[].  (Really, the only reason we have
> these types at all is that we depend on having compile-time-constant
> field sizes in the system catalogs that are accessed via
> include/catalog/'s struct declarations...)

Renamed oid8 ->oidvector and int28->int2vector.  initdb everyone.  New
type names require it.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Vince Vielhaber
Date:
Subject: Simmultanous Connections (fwd)
Next
From: Bruce Momjian
Date:
Subject: oid8/int28