Re: [PATCH] xlogreader: do not read a file block twice - Mailing list pgsql-hackers

From Arthur Zakirov
Subject Re: [PATCH] xlogreader: do not read a file block twice
Date
Msg-id 1fa0c9fe-32a5-3ebd-e9c2-b5e2c9abc03e@postgrespro.ru
Whole thread Raw
In response to Re: [PATCH] xlogreader: do not read a file block twice  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH] xlogreader: do not read a file block twice  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 12.02.2019 07:23, Michael Paquier wrote:
>> On 02/11/2019 07:25 PM, Arthur Zakirov wrote:
>>> Grigory noticed that one of our utilities has very slow performance when
>>> xlogreader reads zlib archives. We found out that xlogreader sometimes
>>> reads a WAL file block twice.
>>>
>>> What do you think?
> 
> I think that such things, even if they look simple, need a careful
> lookup, and I have not looked at the proposal yet.  Could you add it
> to the next commit fest so as we don't lose track of it?
> https://commitfest.postgresql.org/22/

Of course. Agree, it may be a non trivial case. Added as a bug fix:
https://commitfest.postgresql.org/22/1994/

-- 
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company


pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: proposal: variadic argument support for least, greatest function
Next
From: Antonin Houska
Date:
Subject: Re: Problems with plan estimates in postgres_fdw