Re: Evaluate arguments of correlated SubPlans in the referencing ExprState - Mailing list pgsql-hackers

From Alena Rybakina
Subject Re: Evaluate arguments of correlated SubPlans in the referencing ExprState
Date
Msg-id 1eb25f90-fc77-436e-b967-78d465d77a54@yandex.ru
Whole thread Raw
In response to Re: Evaluate arguments of correlated SubPlans in the referencing ExprState  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 18.07.2024 23:01, Tom Lane wrote:
> Alena Rybakina <lena.ribackina@yandex.ru> writes:
>> I fixed it. The code remains the same.
> I see the cfbot is again complaining that this patch doesn't apply.
>
> In hopes of pushing this over the finish line, I fixed up the (minor)
> patch conflict and also addressed the cosmetic complaints I had
> upthread [1].  I think the attached v4 is committable.  If Andres is
> too busy, I can push it, but really it's his patch ...
>
> (BTW, I see no need for additional test cases.  Coverage checks show
> that all this code is reached during the core regression tests.)
>
>             regards, tom lane
>
> [1] https://www.postgresql.org/message-id/2618533.1677874158%40sss.pgh.pa.us
>
Thank you for your contribution! I looked at the patch again and I agree 
that it is ready to be pushed.




pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Add privileges test for pg_stat_statements to improve coverage
Next
From: Tom Lane
Date:
Subject: Re: Wrong results with grouping sets