[PATCH] pgarchives: pglister_sync: import lists with subscriber_access set to True - Mailing list pgsql-www

From Célestin Matte
Subject [PATCH] pgarchives: pglister_sync: import lists with subscriber_access set to True
Date
Msg-id 1d060463-e562-7783-decd-b5a7f3c4c06c@cmatte.me
Whole thread Raw
Responses Re: [PATCH] pgarchives: pglister_sync: import lists with subscriber_access set to True  (Célestin Matte <celestin.matte@cmatte.me>)
Re: [PATCH] pgarchives: pglister_sync: import lists with subscriber_access set to True  (Magnus Hagander <magnus@hagander.net>)
List pgsql-www
pglister_sync.py is a script used to synchronize things between pglister and pgarchives: lists, subscribers etc.

subscriber_access is not set in pglister_sync's query, and is set to null=False in Django's model. As a consequence,
pglister_syncfails to add new lists:
 
Traceback (most recent call last):
  File "/srv/pgarchives/local/loader/pglister_sync.py", line 68, in <module>
    'groupname': l['group']['groupname'],
psycopg2.errors.NotNullViolation: null value in column "subscriber_access" violates not-null constraint
DETAIL:  Failing row contains (8, test-pglister-sync, test-pglister-sync, , t, 1, null).

I don't know if there is a way to configure postgres to use the default value , but I think it would be wiser to
explicitlyset this variable in pglister_sync.py.
 


By default, subscriber_access is set to False and there is no way to modify that within the web interface.
As a consequence, access to lists on private servers is restricted to superusers, and there is no easier way to modify
thatthan to edit the database manually.
 

It seems more logical to me that this value be set to True by default, as access can still be moderated to avoid lists
beingpublicly available.
 

That said, it may be better to have a way to modify that within the web interface in pglister.

-- 
Célestin Matte
Attachment

pgsql-www by date:

Previous
From: Eric Feng
Date:
Subject: Re: Wiki editor request
Next
From: Célestin Matte
Date:
Subject: Re: [PATCH] pgarchives: pglister_sync: import lists with subscriber_access set to True