Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h - Mailing list pgsql-committers

From David Steele
Subject Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date
Msg-id 1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net
Whole thread Raw
In response to pgsql: Avoid -Wconversion warnings when using checksum_impl.h  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
List pgsql-committers
Hi Michael,

On 3/5/20 12:13 AM, Michael Paquier wrote:
> Avoid -Wconversion warnings when using checksum_impl.h
> 
> This does not matter much when compiling Postgres proper as many
> warnings exist when enabling this compilation flag, but it can be
> annoying for external modules willing to use both.

Looks like you changed 65535 -> 65536 before commit.  I checked the 
original patch and it has 65535.

Bit of a bummer that this passed make check-world, but the pgBackRest 
tests definitely did not like it.

Thanks,
-- 
-David
david@pgmasters.net



pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Remove RangeIOData->typiofunc
Next
From: Magnus Hagander
Date:
Subject: Re: pgsql: Revert "initdb: Change authentication defaults"