Re: Bug in ProcArrayApplyRecoveryInfo for snapshots crossing 4B, breaking replicas - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: Bug in ProcArrayApplyRecoveryInfo for snapshots crossing 4B, breaking replicas
Date
Msg-id 1b8b2841-a99c-75ca-10fb-73f2ed883013@enterprisedb.com
Whole thread Raw
In response to Re: Bug in ProcArrayApplyRecoveryInfo for snapshots crossing 4B, breaking replicas  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 1/26/22 23:54, Michael Paquier wrote:
> On Wed, Jan 26, 2022 at 07:31:00PM +0100, Tomas Vondra wrote:
>> I actually tried doing that, but I was not very happy with the result. The
>> test has to call pg_resetwal, but then it also has to fake pg_xact data and
>> so on, which seemed a bit ugly so did not include the test in the patch.
> 
> Indeed, the dependency to /dev/zero is not good either.  The patch
> logic looks good to me.

OK, I've pushed the patch. We may consider adding a TAP test later, if 
we find a reasonably clean approach.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Unlogged relations and WAL-logging
Next
From: Robert Haas
Date:
Subject: Re: pgsql: Server-side gzip compression.