Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: pg_ctl: Detect current standby state from pg_control - Mailing list pgsql-committers

From Peter Eisentraut
Subject Re: pgsql: pg_ctl: Detect current standby state from pg_control
Date
Msg-id 1b5f8f59-e3b4-b158-ef88-d409b413ec43@2ndquadrant.com
Whole thread Raw
In response to Re: pgsql: pg_ctl: Detect current standby state from pg_control  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tree view 
On 9/26/16 8:53 AM, Tom Lane wrote:
> I think that it's 100% pointless for get_control_dbstate
> to be worried about transient CRC failures.  If writes to pg_control
> aren't atomic then we have problems enormously larger than whether
> "pg_ctl promote" throws an error or not.

The new code was designed to handle that, but if we think it's not an
issue, then we can simplify it.  I'm on it.

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Refactor script execution state machine in pgbench.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix newly-introduced issues in pgbench.