pg_dump, and strings - Mailing list pgsql-hackers

From Ansley, Michael
Subject pg_dump, and strings
Date
Msg-id 1BF7C7482189D211B03F00805F8527F748C1DE@S-NATH-EXCH2
Whole thread Raw
Responses Re: [HACKERS] pg_dump, and strings  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: [HACKERS] pg_dump, and strings  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Hi, all

In pg_dump there is a file called common.c.  This file has some string
handling routines in it that return a pointer to a fixed-length, static
string (char *).  I need to remove the fixed-length bit (besides the fact
fact that this is horrendously un-threadsafe).  So, what is the best
mechanism to use on replacement?  There seem to be two fairly standard
methods to use, a) make the calling function allocate the memory it
requires, and pass that in to the called function, or b) the called function
allocates memory using a documented call (say, malloc), and hands
responsibility for freeing the memory to the calling function.  Given the
non-fixed-length constraint, the second option would appear better, but does
any body out there have any other ideas?

MikeA


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgaccess for 6.5.3
Next
From: wieck@debis.com (Jan Wieck)
Date:
Subject: Re: [HACKERS] Function-manager redesign: second draft (long)