RE: [HACKERS] Lex and things... - Mailing list pgsql-hackers

From Ansley, Michael
Subject RE: [HACKERS] Lex and things...
Date
Msg-id 1BF7C7482189D211B03F00805F8527F70ED12B@S-NATH-EXCH2
Whole thread Raw
List pgsql-hackers
As far as I understand it, the MAX_PARSE_BUFFER limit only applies if char
parsestring[] is used, not if char *parsestring is used.  This is the whole
reason for using flex.  And scan.l is set up to compile using char
*parsestring, not char parsestring[].

The NAMEDATALEN limit is imposed by the db structure, and is the limit of an
identifier.  Because this is not actual data, I'm not too concerned with
this at the moment.  As long as we can get pretty much unlimited data into
the tuples, I don't care what I have to call my tables, views, procedures,
etc.

>> 
>> Ansley, Michael wrote:
>> 
>> > >> Hmm. There is something going on to remove fixed length limits
>> > >> entirely, maybe someone is already doing something to lexer in
>> > >> that respect? If no, I could look at what can be done there.
>> > Yes, me.  I've removed the query string limit from psql, libpq, and as
much
>> > of the backend as I can see.  I have done some (very) preliminary
testing,
>> > and managed to get a 95kB query to execute.  However, the two remaining
>> > problems that I have run into so far are token size (which you have
just
>> > removed, many thanks ;-), 
>> 
>> I'm afraid not. There is arbitrary limit (named NAMEDATALEN) 
>> in lexer.
>> If identifier exeeds it, it gets '\0' at that limit, so truncated
>> effectively. Strings are also limited by MAX_PARSE_BUFFER which is
>> finally something like QUERY_BUF_SIZE = 8k*2.
>> 
>> Seems that string literals are the primary target, because it is
>> real-life constraint here now. This is not the case with supposed
>> huge identifiers. Should I work on it, or will you do it yourself?
>> 
>> > and string literals, which are limited, it seems
>> > to YY_BUF_SIZE (I think).
>> 
>> -- 
>> Leon.
>> 


pgsql-hackers by date:

Previous
From: Leon
Date:
Subject: Re: [HACKERS] Lex and things...
Next
From: Adriaan Joubert
Date:
Subject: Re: [HACKERS] Lex and things...