> "Pedro J. Lobo" <pjlobo@euitt.upm.es> writes:
> > Someone has changed the "#if defined(__alpha)" tests that existed in
> > include/storage/s_lock.h in 6.5.1 to "#if defined(__alpha__)". The problem
> > is that DEC (�Compaq?) C only defines __alpha, (gcc defines both __alpha
> > and __alpha__) so it doesn't work anymore.
>
> I thought that was bogus when it was done. Should be
> #if defined(__alpha) || defined(__alpha__)
> to cover both compilers.
>
> > In fact, there are two places where the test is used, one inside a "#if
> > defined(__GNUC__)" and the other one inside the corresponding "#else". It
> > seems that the easiest sollution is to change the check inside the "#else"
> > back to "#if defined(__alpha)".
>
> ... which would break whichever compiler is being used by the person who
> submitted the patch. I don't think it was changed on a whim.
I recommend putting something in the alpha template to define __alpha,
so we don't have to double-compare everywhere. I will make the change
now.
--
Bruce Momjian | http://www.op.net/~candle
maillist@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
