Re: [HACKERS] Problems with src/pl/tcl/mkMakefile.tcldefs.sh.in in 6.5 - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] Problems with src/pl/tcl/mkMakefile.tcldefs.sh.in in 6.5
Date
Msg-id 199907101436.KAA18000@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Problems with src/pl/tcl/mkMakefile.tcldefs.sh.in in 6.5  (pgsql-hackers@thewrittenword.com)
Responses Re: [HACKERS] Problems with src/pl/tcl/mkMakefile.tcldefs.sh.in in 6.5
Re: [ADMIN] Re: [HACKERS] Problems with src/pl/tcl/mkMakefile.tcldefs.sh.in in 6.5
List pgsql-hackers
> On Sat, Jul 10, 1999 at 02:45:47AM -0400, Bruce Momjian wrote:
> > I didn't understand this the first time you sent it either.
> > 
> > Send me a patch to review, please.
> 
> --- src/pl/tcl/mkMakefile.tcldefs.sh.in.orig    Fri Jul  9 08:29:09 1999
> +++ src/pl/tcl/mkMakefile.tcldefs.sh.in    Fri Jul  9 08:29:49 1999
> @@ -8,9 +8,6 @@
>  
>  cat @TCL_CONFIG_SH@ |
>      egrep '^TCL_|^TK_' |
> -    while read inp
> -    do
> -        eval eval echo $inp
> -    done >Makefile.tcldefs
> +    sed -e "s/^\([^=]*\)='\(.*\)'$/\1=\2/" >Makefile.tcldefs
>  

I understand what your patch does, and it looks OK, but any idea why the
'eval eval' was there, and is it safe to skip it?  I can apply this to
6.6.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: pgsql-hackers@thewrittenword.com
Date:
Subject: Re: [HACKERS] Problems with src/pl/tcl/mkMakefile.tcldefs.sh.in in 6.5
Next
From: Chris Bitmead
Date:
Subject: Unique index problem