Re: [HACKERS] "24" < INT_MIN returns TRUE ??? - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] "24" < INT_MIN returns TRUE ???
Date
Msg-id 199907091707.NAA02248@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] "24" < INT_MIN returns TRUE ???  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] "24" < INT_MIN returns TRUE ???
List pgsql-hackers
> I said:
> > Do you have <limits.h>, and if so how does it define INT_MIN?
> 
> Actually, looking closer, it doesn't matter whether you have <limits.h>,
> because there is yet a *third* bug in numutils.c:
> 
>     #ifdef HAVE_LIMITS
>     #include <limits.h>
>     #endif
> 
> should be
> 
>     #ifdef HAVE_LIMITS_H
>     ...
> 
> because that is how configure and config.h spell the configuration
> symbol.  Thus, <limits.h> is never included on *any* platform,
> and our broken default INT_MIN is always used.

Yes, I caught this when you made that comment about the LIMIT test.  I
am checking all the other HAVE_ tests.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Mailing list volume
Next
From: Bruce Momjian
Date:
Subject: Re: Hashing passwords (was Updated TODO list)