Re: [SQL] RewriteDefine.c : Rule size - Mailing list pgsql-sql

From Bruce Momjian
Subject Re: [SQL] RewriteDefine.c : Rule size
Date
Msg-id 199907091656.MAA01689@candle.pha.pa.us
Whole thread Raw
In response to Re: [SQL] RewriteDefine.c : Rule size  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-sql
> There is a poorly-documented restriction that BLCKSZ can't exceed 32K
> (IIRC, this is because block offsets are stored in signed shorts somewhere).
> Probably would be a good idea to mention this in the comments in
> config.h.in.
> 
> For the long run it would be nice to remove the restriction.  I have no
> idea whether that would be easy or hard.  Ideally we could do something
> like
> 
> #if BLCKSZ > 32767
>     typedef int BlockOffset;
> #else
>     typedef short BlockOffset;
> #endif
> 
> but finding all the places that need to use the typedef might be a pain.

Added comment to config.h.in, and TODO item:
* Allow BLCKSZ <= 64k, not <= 32k

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-sql by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [SQL] Good Optimization
Next
From: Bruce Momjian
Date:
Subject: Re: [SQL] RewriteDefine.c : Rule size