Re: [BUGS] General Bug Report: TEMP TABLES becomes permanent CATALOG TABLES - Mailing list pgsql-bugs

> > Test Case:
> > ----------
> > psql mydb
> > mydb=> select * into temp table TMP from anytable;
> > mydb=> drop table invalidTable;
> > mydb=> \q
> > psql mydb
> > mydb=> \dS    --> You will see a new permanent system table.
>
> I can confirm that this a bug.  I am looking at it now.  As a
> workaround, you can delete the temp tables by starting a postgres
> backend with the -O flag to allow system table modifications, and
> droping the table.

OK, I have fixed the problem, and the patch is attached.  The fix will
appear in 6.5.1, due out in mid-July.

The problem is that the temp tables are removed on exit, but they were
not given their own transaction, and were executed in the last
transaction of the session.  If that last session was aborted, the
entries were not being removed from pg_class.

If anyone thinks doing a transaction on exit is a bad idea, please let
me know.

--
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
? src/Makefile.custom
? src/config.log
? src/log
? src/config.cache
? src/config.status
? src/GNUmakefile
? src/Makefile.global
? src/backend/fmgr.h
? src/backend/parse.h
? src/backend/postgres
? src/backend/global1.bki.source
? src/backend/local1_template1.bki.source
? src/backend/global1.description
? src/backend/local1_template1.description
? src/backend/bootstrap/bootparse.c
? src/backend/bootstrap/bootstrap_tokens.h
? src/backend/bootstrap/bootscanner.c
? src/backend/catalog/genbki.sh
? src/backend/catalog/global1.bki.source
? src/backend/catalog/global1.description
? src/backend/catalog/local1_template1.bki.source
? src/backend/catalog/local1_template1.description
? src/backend/port/Makefile
? src/backend/utils/Gen_fmgrtab.sh
? src/backend/utils/fmgr.h
? src/backend/utils/fmgrtab.c
? src/bin/cleardbdir/cleardbdir
? src/bin/createdb/createdb
? src/bin/createlang/createlang
? src/bin/createuser/createuser
? src/bin/destroydb/destroydb
? src/bin/destroylang/destroylang
? src/bin/destroyuser/destroyuser
? src/bin/initdb/initdb
? src/bin/initlocation/initlocation
? src/bin/ipcclean/ipcclean
? src/bin/pg_dump/Makefile
? src/bin/pg_dump/pg_dump
? src/bin/pg_id/pg_id
? src/bin/pg_passwd/pg_passwd
? src/bin/pg_version/Makefile
? src/bin/pg_version/pg_version
? src/bin/pgtclsh/mkMakefile.tcldefs.sh
? src/bin/pgtclsh/mkMakefile.tkdefs.sh
? src/bin/pgtclsh/Makefile.tkdefs
? src/bin/pgtclsh/Makefile.tcldefs
? src/bin/pgtclsh/pgtclsh
? src/bin/pgtclsh/pgtksh
? src/bin/psql/Makefile
? src/bin/psql/psql
? src/include/version.h
? src/include/config.h
? src/interfaces/ecpg/lib/Makefile
? src/interfaces/ecpg/lib/libecpg.so.3.0.0
? src/interfaces/ecpg/preproc/ecpg
? src/interfaces/libpgtcl/Makefile
? src/interfaces/libpgtcl/libpgtcl.so.2.0
? src/interfaces/libpq/Makefile
? src/interfaces/libpq/libpq.so.2.0
? src/interfaces/libpq++/Makefile
? src/interfaces/libpq++/libpq++.so.3.0
? src/interfaces/odbc/GNUmakefile
? src/interfaces/odbc/Makefile.global
? src/lextest/lex.yy.c
? src/lextest/lextest
? src/pl/plpgsql/src/Makefile
? src/pl/plpgsql/src/mklang.sql
? src/pl/plpgsql/src/pl_gram.c
? src/pl/plpgsql/src/pl.tab.h
? src/pl/plpgsql/src/pl_scan.c
? src/pl/plpgsql/src/libplpgsql.so.1.0
? src/pl/tcl/mkMakefile.tcldefs.sh
? src/pl/tcl/Makefile.tcldefs
? src/template/linux_m68k
Index: src/backend/postmaster/postmaster.c
===================================================================
RCS file: /usr/local/cvsroot/pgsql/src/backend/postmaster/postmaster.c,v
retrieving revision 1.106
diff -c -r1.106 postmaster.c
*** src/backend/postmaster/postmaster.c    1999/06/04 21:14:46    1.106
--- src/backend/postmaster/postmaster.c    1999/07/02 18:03:17
***************
*** 1483,1490 ****
       * Let's clean up ourselves as the postmaster child
       */

!     on_exit_reset();            /* we don't want the postmaster's
!                                  * proc_exit() handlers */

      /* ----------------
       *    register signal handlers.
--- 1483,1490 ----
       * Let's clean up ourselves as the postmaster child
       */

!     /* We don't want the postmaster's proc_exit() handlers */
!     on_exit_reset();

      /* ----------------
       *    register signal handlers.
Index: src/backend/tcop/postgres.c
===================================================================
RCS file: /usr/local/cvsroot/pgsql/src/backend/tcop/postgres.c,v
retrieving revision 1.118
diff -c -r1.118 postgres.c
*** src/backend/tcop/postgres.c    1999/05/29 10:25:30    1.118
--- src/backend/tcop/postgres.c    1999/07/02 18:03:20
***************
*** 1483,1499 ****
          puts("\treset_client_encoding() done.");
  #endif

-     /* ----------------
-      * if stable main memory is assumed (-S(old) flag is set), it is necessary
-      * to flush all dirty shared buffers before exit
-      * plai 8/7/90
-      * this used to be done further down, causing an additional entry in
-      * the shmem exit list for every error :-( ... tgl 10/1/98
-      * ----------------
-      */
-     if (!TransactionFlushEnabled())
-         on_shmem_exit(FlushBufferPool, NULL);
-
      on_shmem_exit(remove_all_temp_relations, NULL);

      /* ----------------
--- 1483,1488 ----
Index: src/backend/utils/cache/temprel.c
===================================================================
RCS file: /usr/local/cvsroot/pgsql/src/backend/utils/cache/temprel.c,v
retrieving revision 1.4
diff -c -r1.4 temprel.c
*** src/backend/utils/cache/temprel.c    1999/05/25 22:42:16    1.4
--- src/backend/utils/cache/temprel.c    1999/07/02 18:03:21
***************
*** 30,35 ****
--- 30,36 ----
  #include "nodes/pg_list.h"
  #include "utils/mcxt.h"
  #include "utils/temprel.h"
+ #include "access/xact.h"
  #include "access/htup.h"
  #include "access/heapam.h"
  #include "catalog/heap.h"
***************
*** 79,84 ****
--- 80,87 ----
      List       *l,
                 *next;

+     StartTransactionCommand();
+
      l = temp_rels;
      while (l != NIL)
      {
***************
*** 102,107 ****
--- 105,111 ----

          l = next;
      }
+     CommitTransactionCommand();
  }

  /* we don't have the relname for indexes, so we just pass the oid */