Re: [HACKERS] aggregation memory leak and fix - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] aggregation memory leak and fix
Date
Msg-id 199903201250.HAA19354@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] aggregation memory leak and fix  (Erik Riedel <riedel+@CMU.EDU>)
List pgsql-hackers
> 
> > No apologies necessary.  Glad to have someone digging into that area of
> > the code.  We will gladly apply your patches to 6.5.  However, I request
> > that you send context diffs(diff -c).  Normal diffs are just too
> > error-prone in application.   Send them, and I will apply them right
> > away.
> >  
> Context diffs attached.  This was due to my ignorance of diff.  When I
> made the other files, I though "hmm, these could be difficult to apply
> if the code has changed a bit, wouldn't it be good if they included a
> few lines before and after the fix".  Now I know "-c".

We are seeing regression failure on aggregates after the patches.  It is
happening in nodeAgg.c, line 379:

                     pfree(oldVal); /* XXX - new, let's free the old datum -$


--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Michael Meskes
Date:
Subject: CVS target for docs
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] min() and max() causing aborts