Re: [HACKERS] Upgrades for 6.4.1 - Mailing list pgsql-hackers

Would people please review the attached TODO list, and tell me what TODO  items can be removed, and if the attached
6.4.1changes are correct.
 

It looks from your list like a couple of patches I sent in have not
made it in for one reason or another, though I haven't checked the
source yet but never saw any acknowledgement.

Here are descriptions:

- the first patch is just to preven listing the perl warning in the make output unless it is actually emitted by the
make. this may prevent new users from being confused by the warning in their output when in fact is is just echoing
partof a command not actually run.
 

- the second patch (to 2 files) just enables building/installing pgaccess if TCL and TK are available.  a Makefile is
createdto do this, but you may wish to change the heading information in it since I just copied another Makefile to use
asa template.
 

I hope these make it into 6.4.1.

Cheers,
Brook

===========================================================================
$NetBSD$

--- interfaces/Makefile.orig    Tue Oct 27 14:27:36 1998
+++ interfaces/Makefile    Fri Nov  6 23:12:08 1998
@@ -48,11 +48,11 @@perl5/Makefile: perl5/Makefile.PL    cd perl5 && perl Makefile.PL
-install-perl5:
+install-perl5: perl5/Makefile    $(MAKE) -C perl5 clean    cd perl5 && POSTGRES_HOME="$(POSTGRESDIR)" perl Makefile.PL
  $(MAKE) -C perl5 all
 
-    if [ -w `sed -n -e 's/^ *SITELIBEXP *= *//p' perl5/Makefile` ]; then \
+    @if [ -w `sed -n -e 's/^ *SITELIBEXP *= *//p' perl5/Makefile` ]; then \        $(MAKE) $(MFLAGS) -C perl5 install;
\       rm -f perl5/Makefile; \    else \
 
===========================================================================
$NetBSD$

--- bin/Makefile.orig    Sat Jul 25 22:31:08 1998
+++ bin/Makefile    Mon Nov  9 08:35:00 1998
@@ -25,6 +25,9 @@# TCL/TK programs#ifeq ($(USE_TCL), true)
+ifeq ($(USE_TK), true)
+    DIRS += pgaccess
+endif    DIRS += pgtclshendif
$NetBSD$

--- bin/pgaccess/Makefile.orig    Fri Nov  6 23:43:38 1998
+++ bin/pgaccess/Makefile    Fri Nov  6 23:46:26 1998
@@ -0,0 +1,21 @@
+#-------------------------------------------------------------------------
+#
+# Makefile
+#    Makefile for pgaccess
+#
+# Copyright (c) 1994, Regents of the University of California
+#
+# IDENTIFICATION
+#    $Header: /usr/local/cvsroot/pgsql/src/interfaces/libpgtcl/Makefile.in,v 1.33 1998/10/19 00:00:41 tgl Exp $
+#
+#-------------------------------------------------------------------------
+
+SRCDIR= ../..
+include $(SRCDIR)/Makefile.global
+
+.PHONY: all clean
+all clean: 
+
+.PHONY: install
+install: pgaccess.tcl
+    $(INSTALL) $(INSTL_EXE_OPTS) pgaccess.tcl $(BINDIR)/pgaccess
===========================================================================