Re: [HACKERS] Please check...ignore them... - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] Please check...ignore them...
Date
Msg-id 199812140403.XAA06781@candle.pha.pa.us
Whole thread Raw
In response to Please check...ignore them...  (The Hermit Hacker <scrappy@hub.org>)
List pgsql-hackers
> 
> Everything is in CVS, if I oops, its recoverable...am removing all code
> that has either:
> 
> #if 0
> 
> or 
> 
> #ifdef FALSE
> 
> surrounding it, since it isn't used...we have the logs and diffs in the
> CVS repository if I make a mistake, but since it isn't used, can't see how
> I can make a mistake :)

Yep, except there is some code if'defed out that could be useful some
day.  The one from dbcommand.c clearly would never be useful. 
Basically, if you can figure out what the ifdef 0 did, and you see a
replacement in the code, you can remove it.  That is the guide I use.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: The Hermit Hacker
Date:
Subject: Reason for commands/user.c?
Next
From: The Hermit Hacker
Date:
Subject: Alot of code...NOT_USED...