Re: [HACKERS] memory destruction in 6.4 - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: [HACKERS] memory destruction in 6.4
Date
Msg-id 199812131114.UAA00943@ext16.sra.co.jp
Whole thread Raw
In response to Re: [HACKERS] memory destruction in 6.4  (Bruce Momjian <maillist@candle.pha.pa.us>)
List pgsql-hackers
> Applied to both trees.
> 
> 
> 
> > While investigating a user's complaint, I have found some memory
> > destructions in 6.4 source using purify.
> > 
> > (1) parser/gram.y:fmtId()
> > 
> > It writes n+3 bytes into n+1 byte-long memory area if mixed case or
> > non-ascii identifiers given.
> > 
> > (2) catalog/index.c:
> > 
> > ATTRIBUTE_TUPLE_SIZE bytes are allocated but
> > sizeof(FormData_pg_attribute) bytes are written. Note that
> > ATTRIBUTE_TUPLE_SIZE is smaller than
> > sizeof(FormData_pg_attribute). (for example, on solaris 2.6,
> > ATTRIBUTE_TUPLE_SIZE is 3 bytes smaller).
> > 
> > Attached patches try to fix the problem. I do not check all of sources 
> > and there may be similar mistakes remained, however.
> > --
> > Tatsuo Ishii

Thank you for taking care of my patches.
---
Tatsuo Ishii


pgsql-hackers by date:

Previous
From: "Thomas G. Lockhart"
Date:
Subject: Re: [HACKERS] Parser bug (?)
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] COMMIT