Re: [HACKERS] Re: [QUESTIONS] UPDATE statement ORACLE 6 compatible - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] Re: [QUESTIONS] UPDATE statement ORACLE 6 compatible
Date
Msg-id 199803200359.WAA24472@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Re: [QUESTIONS] UPDATE statement ORACLE 6 compatible  ("Thomas G. Lockhart" <lockhart@alumni.caltech.edu>)
List pgsql-hackers
>
> This is a multi-part message in MIME format.
> --------------5B2D8E5180AAC1149F41A1FA
> Content-Type: text/plain; charset=us-ascii
> Content-Transfer-Encoding: 7bit
>
> > > So, the patch for "function() BETWEEN" helps, but I'm still not sure
> > > it is safe, since I don't know how these nodes might be handled
> > > deeper in the backend.
> >
> > Ship the patch over here and I will have a look at it.
>
> OK, here it is...

Applied.  There is a nice comment, and it just prevents an elog().  I
think your logic is correct.  There are several cases, I think, where
strings are used multiple places.  Also, you are just preventing
reprocessing of the args.  We can perhaps improve this later if a
problem comes up.

--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Alpha initdb fixed!
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] tables >2GB