Re: [HACKERS] Re: [PATCHES] patches for 6.2.1p6 - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] Re: [PATCHES] patches for 6.2.1p6
Date
Msg-id 199803171420.JAA12842@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Re: [PATCHES] patches for 6.2.1p6  (The Hermit Hacker <scrappy@hub.org>)
Responses Re: [HACKERS] Re: [PATCHES] patches for 6.2.1p6
List pgsql-hackers
>
> On Mon, 16 Mar 1998, David Gould wrote:
>
> > If this will work, I am willing to hack this together tomorrow.
> > What is the time frame for accepting a patch like this?
>
>     Assuming that its *clean* (clean meaning that Bruce fully approves
> of it, as this is his area of the code...well, one of them
> *grin*)...tomorrow would be great :)  If Bruce has *any* doubts though, it
> doesn't go in until after I do the patch I want to do...

David, go for it.  The code is all local in two files, and I think you
can basically change all the do{test-and-set} while(lock-is-false)
loops to:

    do{test-and-set} while(lock-is-false && select ())

Pretty easy.  No need to test multiple platforms.  The ones where the
loop is integrated into the asm(), leave them for later.

--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)

pgsql-hackers by date:

Previous
From: Mattias Kregert
Date:
Subject: Regression test
Next
From: Bruce Momjian
Date:
Subject: Re: Unix Domain Sockets error (was Re: [HACKERS] Alpha initdb fixed!)