Re: [HACKERS] port/getrusage.c? - Mailing list pgsql-hackers

From Hal Snyder
Subject Re: [HACKERS] port/getrusage.c?
Date
Msg-id 199803120651.AAA02072@crocodile.vail
Whole thread Raw
Responses Re: [HACKERS] port/getrusage.c?]
List pgsql-hackers
> From: dg@illustra.com (David Gould)
> Date: Wed, 11 Mar 1998 22:37:59 -0800 (PST)

...
> > Good question. I don't see one, but the config stuff is not familiar
> > ground. There is reference to "sco" on line 85 of
> >
> >   src/include/utils/memutils.h - "#if ! defined(sco)"
> >
> > but I think nothing sets this any more. (Actually this is another
> > thing on the list of SCO breakage in 6.3). I'd add something to the
> > template for sco.

> What is the policy for defines on Postgres?
>
> It is often suggested that that 'ifdef defined(RANDOM_PLATFORM)' is not a
> nice way to proceed. Far better to use for example 'defined(HAS_FEATURE_XYZ)'
> than something like:
>
> 'defined(SOLARIS) or defined(SUNOS) or defined(PYRAMID) && !defined(WIN32)'.
>
> In the case at hand, perhaps something like  'if defined(BROKEN_CPP_GCC_271)',
> and then define it in the SCO part of the build system. After all, SCO
> might survive long enough to upgrade to a current compiler...

Ack. How about changing

  CFLAGS:

to

  CFLAGS:-DLAME_CPP

in src/templates/sco?


pgsql-hackers by date:

Previous
From: "박귀태"
Date:
Subject: ...
Next
From: "Vadim B. Mikheev"
Date:
Subject: Re: [HACKERS] Timetravel vs checkpointing and no read-locking