Re: pgsql: Remove ineffective check against dropped columns from slot_getat - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Remove ineffective check against dropped columns from slot_getat
Date
Msg-id 19979.1541909357@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Remove ineffective check against dropped columns fromslot_getat  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
Andres Freund <andres@anarazel.de> writes:
> On 2018-11-11 01:11:34 +1300, David Rowley wrote:
>> Would it not be worth an Assert(!TupleDescAttr(tupleDesc, attnum -
>> 1)->attisdropped); so that we're more likely to discover any issues
>> where cached plans are not invalidated correctly?

> I don't think it'd really do much.

FWIW, I agree.  We'd need assertions in many more places than this
if we wanted reasonable coverage on the point, and I doubt it's
worth the work.

            regards, tom lane


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Disable MSVC warning caused by recent snprintf.c changes
Next
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Remove dead foreign key optimization code