Re: gcc versus division-by-zero traps - Mailing list pgsql-hackers

From Tom Lane
Subject Re: gcc versus division-by-zero traps
Date
Msg-id 19979.1251998812@sss.pgh.pa.us
Whole thread Raw
In response to Re: gcc versus division-by-zero traps  (David Fetter <david@fetter.org>)
Responses Re: gcc versus division-by-zero traps
List pgsql-hackers
David Fetter <david@fetter.org> writes:
> On Thu, Sep 03, 2009 at 10:24:17AM -0400, Tom Lane wrote:
>> While s390x is still not quite mainstream, at least I can get
>> access to one ;-).

> Do you also have access to z/OS with Unix System Services?

No, Red Hat's machines run RHEL ;-)

>> What I am thinking is that in the three
>> functions known to exhibit the bug (int24div, int28div, int48div)
>> we should do something like this:

> How big would this change be?  How would people know to use that
> construct everywhere it's appropriate?

I'm talking about patching exactly those three functions.  We don't
have any reports of trouble elsewhere.  The long-term fix is in the
compiler anyway, this is just a workaround for currently-known issues.

Part of my motivation for this is to get rid of an existing hack in
the Red Hat RPMs:

# use -O1 on sparc64 and alpha
%ifarch sparc64 alpha
CFLAGS=`echo $CFLAGS| sed -e "s|-O2|-O1|g" `
%endif

I believe that that is only there to prevent exactly this problem.
Anyway I'd like to try removing it after patching as proposed, and
then we'll find out if there are other trouble spots ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: community decision-making & 8.5
Next
From: Selena Deckelmann
Date:
Subject: Re: community decision-making & 8.5