Re: obsolete reference to a SubPlan field - Mailing list pgsql-hackers

From Tom Lane
Subject Re: obsolete reference to a SubPlan field
Date
Msg-id 199433.1647279900@sss.pgh.pa.us
Whole thread Raw
In response to Re: obsolete reference to a SubPlan field  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: obsolete reference to a SubPlan field  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Feb 2, 2022 at 3:08 AM Amit Langote <amitlangote09@gmail.com> wrote:
>> Attached patch removes those.

> Looks right to me. Tom, any comments?

I'm pretty sure I left those comments alone on purpose back in 2007,
and I don't find simply removing them to be an improvement.

In principle, readers might expect that tree walkers/mutators
would descend to a SubPlan's query, as they do for a SubLink's
query.  Calling out the fact that that doesn't happen seems
useful to me.  If you don't like this particular wording of those
comments, we can discuss better wordings ... but I doubt that
nothing-at-all is better.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Estimating HugePages Requirements?
Next
From: Robert Haas
Date:
Subject: Re: obsolete reference to a SubPlan field