Re: [Patch]Add Graph* node support to expression_tree_mutator - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [Patch]Add Graph* node support to expression_tree_mutator
Date
Msg-id 19895d96-a27a-4e8a-a67f-f6dcf0ed4f82@eisentraut.org
Whole thread
In response to Re: [Patch]Add Graph* node support to expression_tree_mutator  (Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>)
List pgsql-hackers
On 30.04.26 08:44, Ashutosh Bapat wrote:
> On Thu, Apr 30, 2026 at 2:17 AM Robert Haas <robertmhaas@gmail.com> wrote:
>>
> 
> Thanks for reviewing the patch.
> 
>> Thanks for working on this. I ran into it independently today, and
>> then discovered this thread. In expression_tree_mutator_impl,
>> T_GraphLabelRef can be added to the "Primitive node types with no
>> expression subnodes" section just as was done in
>> expression_tree_walker_impl.
> 
> Right. Fixed in the attached patch. Both GraphPropertyLabel and
> GraphLabelRef need to be placed in that section since both are
> primitive nodes.

Committed.  (I reformatted the test query a little bit as you had 
suggested upstream.  Also, the ordering of the switch cases was slightly 
different between the walker and the mutator, which I fixed.)




pgsql-hackers by date:

Previous
From: Lukas Fittl
Date:
Subject: Re: EXPLAIN: showing ReadStream / prefetch stats
Next
From: Nathan Bossart
Date:
Subject: Re: problems with toast.* reloptions