Re: Getting rid of warnings - Mailing list pgsql-patches

From Tom Lane
Subject Re: Getting rid of warnings
Date
Msg-id 19872.1169740649@sss.pgh.pa.us
Whole thread Raw
In response to Getting rid of warnings  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Getting rid of warnings
List pgsql-patches
Magnus Hagander <magnus@hagander.net> writes:
>   bool
> ! isort(int4 *a, int len)
>   {
>   bool
> ! isort(int4 *a, const int len)
>   {

If VC thinks that that is required to fix a warning, it's too broken to live.
AFAICS what you've got there is a compiler that is being pedantically
strict about language details that it does not actually understand well;
its apparent idea that "const **" means "const * const *" being much in
the same line as this one.

I don't mind the non-const-related parts of this patch, but I recommend
rejecting all the const-decoration changes.

            regards, tom lane

pgsql-patches by date:

Previous
From: Magnus Hagander
Date:
Subject: setlocal to build.bat
Next
From: Magnus Hagander
Date:
Subject: Re: Getting rid of warnings